Skip to content

Comments

[AFD WAF] Add exclusions to managed rule set configuration (2019-10-01)#7221

Merged
tjprescott merged 5 commits intoAzure:masterfrom
eschwabe:dev-frontdoor-waf-api-20191001
Oct 2, 2019
Merged

[AFD WAF] Add exclusions to managed rule set configuration (2019-10-01)#7221
tjprescott merged 5 commits intoAzure:masterfrom
eschwabe:dev-frontdoor-waf-api-20191001

Conversation

@eschwabe
Copy link
Contributor

@eschwabe eschwabe commented Sep 16, 2019 •
edited
Loading

Overview

  • Add API Version 2019-10-01 for FrontDoor WAF API
  • Add exclusions to managed rule set configuration at the rule set, rule group, and rule levels
  • Updated examples with valid configurations

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 16, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 7fb78bb, Iteration 3)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@AutorestCI AutorestCI mentioned this pull request Sep 16, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 16, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7571

@AutorestCI
Copy link

AutorestCI commented Sep 16, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@tjprescott tjprescott added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 16, 2019
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Sep 16, 2019
Closed
@azuresdkci
Copy link
Contributor

azuresdkci commented Sep 16, 2019

Can one of the admins verify this patch?

KrisBash
KrisBash suggested changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify the intention, as the 2019-03-01 WAF swagger is being added unchanged to this folder.

...or/resource-manager/Microsoft.Network/stable/2019-10-01/examples/WafListManagedRuleSets.json
@@ -0,0 +1,56 @@
{
Copy link
Contributor

@KrisBash KrisBash Sep 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For new API versions, please copy a prior reviewed API version as the first commit, and then commit the changes. It makes it easier to review deltas in Github natively. Thanks

Copy link
Contributor Author

@eschwabe eschwabe Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first commit should be a copy of the 2019-03-01 API. The subsequent commits have the proposed changes for version 2019-10-01.

KrisBash
KrisBash approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 2, 2019
@tjprescott tjprescott merged commit b7a668f into Azure:master Oct 2, 2019
@AutorestCI AutorestCI mentioned this pull request Oct 2, 2019
Merged
@eschwabe eschwabe mentioned this pull request Nov 6, 2019
Merged
@timja timja mentioned this pull request Jan 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tjprescott tjprescott tjprescott approved these changes

@johsun-msft johsun-msft Awaiting requested review from johsun-msft

+2 more reviewers

@nschonni nschonni nschonni left review comments

@KrisBash KrisBash KrisBash approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tjprescott tjprescott

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@eschwabe @AutorestCI @azuresdkci @nschonni @tjprescott @KrisBash